Skip to content

Missing code of conduct api endpoints #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

Missing code of conduct api endpoints #656

merged 1 commit into from
Dec 12, 2017

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Dec 10, 2017

No description provided.

Nyholm
Nyholm approved these changes Dec 10, 2017
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review. I think it all looks good

@acrobat
Copy link
Collaborator Author

acrobat commented Dec 10, 2017

Thanks @Nyholm, there will be some more pr's coming. I've made an overview of all api endpoints and the one's we're missing!

Nyholm
Nyholm approved these changes Dec 12, 2017
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Will merge after 2.7 is released

@Nyholm Nyholm merged commit 1d4d360 into KnpLabs:master Dec 12, 2017
@acrobat acrobat deleted the api-codeofconduct branch December 12, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acrobat @Nyholm